Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce invalid header union expressions #1220

Merged
merged 3 commits into from
May 2, 2023
Merged

Introduce invalid header union expressions #1220

merged 3 commits into from
May 2, 2023

Conversation

mihaibudiu
Copy link
Contributor

Signed-off-by: Mihai Budiu mbudiu@vmware.com
Fixes #1215

@jafingerhut
Copy link
Collaborator

jafingerhut commented Jan 14, 2023

It is unclear to me that there is any semantic change to the specification intended by these changes to the text. It appears that it might simply be different words to mean the same thing.

Are there any semantic changes intended by this PR? If so, what are they?

I should clarify: I do see the new definition for syntax that represents the value of an invalid header_union. That is new, I agree.

It is the earlier parts of the changes in this PR that I am asking about if there are any intended semantic changes.

@mihaibudiu
Copy link
Contributor Author

It is unclear to me that there is any semantic change to the specification intended by these changes to the text. It appears that it might simply be different words to mean the same thing.

Are there any semantic changes intended by this PR? If so, what are they?

I should clarify: I do see the new definition for syntax that represents the value of an invalid header_union. That is new, I agree.

It is the earlier parts of the changes in this PR that I am asking about if there are any intended semantic changes.

The intent is to clarify the spec, not to change it. There is also an enumeration which seems incomplete.

Mihai Budiu added 2 commits May 1, 2023 11:42
Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
@@ -7413,6 +7430,8 @@ The following are compile-time known values:
- The `_` identifier when used as a `select` expression label
- The expression `{#}` representing an invalid header or header union
value.
- The expression `(HU){#}` representing an invalid header union of type HU.
- The expression `(H){#}` representing an header of type H.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move casts from the list below into a separate bullet and delete the above 2.

…values

Signed-off-by: Mihai Budiu <mbudiu@gmail.com>
@mihaibudiu mihaibudiu requested a review from jnfoster May 1, 2023 22:04
Copy link
Collaborator

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mihaibudiu
Copy link
Contributor Author

As discussed during the LDWG meeting, I will merge this.

@mihaibudiu mihaibudiu merged commit e0a822f into main May 2, 2023
@mihaibudiu mihaibudiu deleted the invalid-union branch May 2, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add expression to represent an invalid header_union value
2 participants