-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce invalid header union expressions #1220
Conversation
It is unclear to me that there is any semantic change to the specification intended by these changes to the text. It appears that it might simply be different words to mean the same thing. Are there any semantic changes intended by this PR? If so, what are they? I should clarify: I do see the new definition for syntax that represents the value of an invalid header_union. That is new, I agree. It is the earlier parts of the changes in this PR that I am asking about if there are any intended semantic changes. |
The intent is to clarify the spec, not to change it. There is also an enumeration which seems incomplete. |
Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
p4-16/spec/P4-16-spec.mdk
Outdated
@@ -7413,6 +7430,8 @@ The following are compile-time known values: | |||
- The `_` identifier when used as a `select` expression label | |||
- The expression `{#}` representing an invalid header or header union | |||
value. | |||
- The expression `(HU){#}` representing an invalid header union of type HU. | |||
- The expression `(H){#}` representing an header of type H. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move casts from the list below into a separate bullet and delete the above 2.
…values Signed-off-by: Mihai Budiu <mbudiu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As discussed during the LDWG meeting, I will merge this. |
Signed-off-by: Mihai Budiu mbudiu@vmware.com
Fixes #1215