Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review #1

Merged
merged 12 commits into from
Apr 14, 2021
Merged

Review #1

merged 12 commits into from
Apr 14, 2021

Conversation

AmedeoSapio
Copy link
Member

Basic READMEs for all the components and initial client library.

@AmedeoSapio AmedeoSapio requested a review from jklr April 13, 2021 00:44
@AmedeoSapio AmedeoSapio self-assigned this Apr 13, 2021
@AmedeoSapio AmedeoSapio added documentation Improvements or additions to documentation library Updates the end-host library labels Apr 13, 2021
jklr
jklr requested changes Apr 13, 2021
View reviewed changes
Copy link
Collaborator

@jklr jklr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many folks can be confused by 'switch p4' naming. Let's use distinctive names specific to switchML.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
dev_root/README.md Outdated Show resolved Hide resolved
dev_root/switch_p4/README.md Outdated Show resolved Hide resolved
dev_root/switch_p4/README.md Outdated Show resolved Hide resolved
jklr
jklr approved these changes Apr 14, 2021
View reviewed changes
Copy link
Collaborator

@jklr jklr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments. I approve it. We may improve the structure further based on community feedback.

@AmedeoSapio
SwitchML P4 code
0c094ee 
The P4 code supports both UDP and RoCEv2, with 256B and 1024B
packets using recirculation.
@AmedeoSapio AmedeoSapio merged commit e942dce into main Apr 14, 2021
@AmedeoSapio AmedeoSapio deleted the review branch April 14, 2021 04:01
@lvleiai123 lvleiai123 mentioned this pull request Jul 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklr jklr jklr approved these changes

Assignees

@AmedeoSapio AmedeoSapio

Labels
documentation Improvements or additions to documentation library Updates the end-host library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AmedeoSapio @jklr @OasisArtisan