Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make declarations global in parser before converting ifs to states #2644

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Make declarations global in parser before converting ifs to states #2644

merged 1 commit into from
Mar 1, 2021

Conversation

mihaibudiu
Copy link
Contributor

Fixes #2409

@mihaibudiu mihaibudiu mentioned this pull request Jan 6, 2021
Closed
9 tasks
jnfoster
jnfoster approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@jnfoster jnfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

One issue I didn't see a test for: I assume the state name generation works when there are multiple conditionals?

@mihaibudiu mihaibudiu merged commit 21fe229 into p4lang:master Mar 1, 2021
@mihaibudiu mihaibudiu deleted the issue2409 branch March 1, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnfoster jnfoster jnfoster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implementation of 'if' statements in parsers is incorrect
2 participants
@mihaibudiu @jnfoster