Compiler Bug : overwriting definitions in defuse (#2900) #2971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bug in file def_use in method setDefinitionsAt class AllDefinitions * In that method definition in map atPoint is overridden * This happens beacuse there is more than one AsssignStatement with the same id * Pass KeySideEffect is creating those AssignStatements (in method KeySideEffect::doStatement) * This method creates a BlockStatement and inserts AssignStatements from TableInsertions variable and then inserts that block before tbl.apply() * Bug is removed by cloning an AssignStatement before inserting it in a BlockStatement * Backend pass CopyMatchKeysToSingleStruct inherits KeySideEffect * Backend uses this pass to transform tables such that all the Match keys are part of the same header/metadata struct * With cloning two test fail (psa-dpdk-table-key-consolidation-if*) in spec file * This happens because for every assignment DpdkMovStatement is created and inserted in instractions (pass ConvertStatementToDpdk) * There is no need for this new DpdkMovStatements because src is already in dest (it is done the first time we call tbl.apply) * This is fixed by setting SideEffect::doStatement to be virtual and overriding it in class CopyMatchKeysToSingleStruct * In this override there is no cloning * Added test for issue 2900 (bug.p4 that was given in issue discussion) * Added expected outputs for that test
|
I just saw PR from mvido, we were dealing with the same issue. |
mihaibudiu
approved these changes
Dec 1, 2021
|
The problem is not that two nodes have the same id, the problem is that the to IR nodes are in fact the same exact node. We keep pointers to nodes in hash-tables, so a node cannot be mapped to two different values in the hash-table. See also the discussion from #2969 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2900
Bug in file def_use in method setDefinitionsAt class AllDefinitions
In that method definition in map atPoint is overridden
This happens beacuse there is more than one AsssignStatement with the same id
Pass KeySideEffect is creating those AssignStatements (in method KeySideEffect::doStatement)
This method creates a BlockStatement and inserts AssignStatements from TableInsertions variable and then inserts that block before tbl.apply()
Bug is removed by cloning an AssignStatement before inserting it in a BlockStatement
Backend pass CopyMatchKeysToSingleStruct inherits KeySideEffect
Backend uses this pass to transform tables such that all the Match keys are part of the same header/metadata struct
With cloning two test fail (psa-dpdk-table-key-consolidation-if*) in spec file
This happens because for every assignment DpdkMovStatement is created and inserted in instractions (pass ConvertStatementToDpdk)
There is no need for this new DpdkMovStatements because src is already in dest (it is done the first time we call tbl.apply)
This is fixed by setting SideEffect::doStatement to be virtual and overriding it in class CopyMatchKeysToSingleStruct
In this override there is no cloning