Convert BUG macros to constexpr variadic functions for better typing. #3774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhavel
reviewed
Dec 12, 2022
lib/exceptions.h
Outdated
| } // namespace Util | ||
|
|
||
| template <class... Args> | ||
| [[noreturn]] inline auto BUG(Args&&... args) { | ||
| throw Util::CompilerBug(__LINE__, __FILE__, std::forward<Args>(args)...); |
There was a problem hiding this comment.
Wouldn't this alter the meaning of __LINE__ and __FILE__?
There was a problem hiding this comment.
Yes and that is why C++20 adds std::source_location:
https://en.cppreference.com/w/cpp/utility/source_location
That is only there for C++20 and not in C++17 mode for GCC.
There was a problem hiding this comment.
Yes, this will not work with C++17 I believe. I was just getting annoyed with warnings about the BUG macros, so I wrote up this draft. Once we switch to C++20, this might be something worth considering.
This new syntax is horrid, though.
fruffy-bfn
force-pushed
the
exception_typing
branch
3 times, most recently
from
a65b46c
to
517bb52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WiP.