Fix broken MacOS and Ubuntu18.04 runs. #4517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
added
run-ubuntu18
fruffy
force-pushed
the
fruffy/mac_os_fixes
branch
6 times, most recently
from
0c19ee6
to
aa3f5b8
Compare
fruffy
force-pushed
the
fruffy/mac_os_fixes
branch
2 times, most recently
from
da61e65
to
756d453
Compare
fruffy
force-pushed
the
fruffy/mac_os_fixes
branch
from
756d453
to
6b677dc
Compare
asl
reviewed
Mar 11, 2024
tools/install_mac_deps.sh
Outdated
| brew_install ${package} | ||
| # FIXME: || true should not be needed but because boost@1.84 pulls in python@3.12, which fails | ||
| # to install we need to ignore the error. | ||
| brew_install ${package} || true |
There was a problem hiding this comment.
Do we know which package has /usr/local/bin/2to3?
There was a problem hiding this comment.
I think it is the Python package.
There was a problem hiding this comment.
I have tried a couple things, including removing 2to3 but there are more files it conflicts with. Even when you install python@3.12 beforehand, the boost installation tries to pull it in again and fails. Maybe there is a convenient flag to deal with that.
There was a problem hiding this comment.
Looks like known issue: actions/runner-images#4020 Some solutions are quite harsh: Gelmo/warfork-qfusion@79f3dd0
fruffy
force-pushed
the
fruffy/mac_os_fixes
branch
from
f88def1
to
97fbb47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfixes to make the CI tests pass again. If anyone has a better idea on how to deal with the recent MacOS failures, please let me know. Example:
https://github.com/p4lang/p4c/actions/runs/8238983424/job/22531194158?pr=4517#step:6:401