Enabling arenas in runtime proto #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkruskal-google
changed the title
antoninbas
reviewed
Apr 20, 2021
|
Looking at when this was flipped on by default back in early 2020, it looks like the main drawback is that the binary size increases a bit. This should be marginal though, and this flag will be deprecated and defaulted to true in future protobuf versions. Since you aren't using arenas, it basically just adds some dead generated code. |
stefanheule
approved these changes
Apr 21, 2021
antoninbas
approved these changes
Apr 21, 2021
|
Are there any outstanding issues? I don't seem to have permission to merge |
|
@mkruskal-google, no I was giving other folks a chance to review. I think we can proceed with the merge. |
|
Great, thanks Antonin!
…On Wed, Apr 21, 2021 at 5:20 PM Antonin Bas ***@***.***> wrote:
Merged #348 <#348> into main.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#348 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO6CNUZ3HGJVOFVM52DWCCTTJ5TWLANCNFSM43JGRPDQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be enabled by default in future versions, and is necessary to generate protobuf arena methods.