github actions #131
Merged
github actions #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antoninbas Any way to stop github from checking travis anymore? Any settings that needs to be changed ? |
antoninbas
reviewed
Nov 13, 2020
There was a problem hiding this comment.
This looks pretty good, thanks for taking care of this
Since the tests are passing, I will update the repo settings so that this check is required and the old one is no longer required. I think you should feel free to remove the travis file altogether. I doubt we will need it again and it will be available in the history anyway.
antoninbas
reviewed
Nov 13, 2020
antoninbas
approved these changes
Nov 13, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.