Correct setting mrtime/mrcode for IGMP #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antoninbas @Yi-Tseng can I please you to review this change? |
antoninbas
reviewed
Dec 16, 2021
Comment on lines
+1
to
+6
| from ptf.testutils import simple_igmp_packet | ||
|
|
||
|
|
||
| def test_simple_igmp_packet__proper_setting_mrtime_mrcode(): | ||
| simple_packet = simple_igmp_packet(igmp_mrtime=10) | ||
| assert simple_packet["IGMP"].mrcode == 10 |
There was a problem hiding this comment.
I don't see this test being run in CI by
ptf/.github/workflows/build.yml
Line 60 in de2b4b3
Maybe the command needs to be modified so that nose2 can run the tests in the new subdirectory.
There was a problem hiding this comment.
Actual, this test is run by the Makefile's command test https://github.com/p4lang/ptf/pull/158/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R17
I planned to do some refactor around all unittests, then I run it into CI, with separate PR.
antoninbas
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #157