Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loadbalancer tutorial #622

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

Selfie21
Copy link
Contributor

This PR fixes an error, where the initially compiling the program leads to an error.
Also adjusted the README to fit the initial behaviour of the program as mentioned in Issue 348

I did not see any guidelines for pull requests, i would be open to change my PR to fit those if they exist.

Copy link
Collaborator

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that your proposed changes are probably less confusing to a newcomer. Thanks!

@jafingerhut jafingerhut merged commit 5cc9026 into p4lang:master Jun 27, 2024
@Selfie21
Copy link
Contributor Author

Cool. Thanks for the nice tutorials and talks, couldn't have imagined a better way to get started with P4 ^^

@Selfie21 Selfie21 deleted the fix-loadbalancer-tutorial branch June 27, 2024 12:39
@jafingerhut jafingerhut mentioned this pull request Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants