Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get resource url from host header #213

Conversation

AndrewChubatiuk
Copy link

Hi @p4tin
First of all want to thank you for your project, it's really helpful.
I'm trying to spin up goaws using docker-compose with dynamic host port mapping and I had problems trying to send a message to URL that was retrieved from GetQueueUrl, cause queue url host and port are based on configuration file instead of HTTP Host header value. Also it's hard to query goaws instance from host and overlay networks at the same time.
I've submitted this PR with a resolution of this problem.

@nhoughto
Copy link

nhoughto commented Mar 4, 2020

Might want to incorporate the config flag as per my fix for your same issue (i saw this after i finished! 🙄 ), not changing the default behaviour likely makes it easier to merge the PR? 🤷‍♂

bsycorp@2f32176

@Admiral-Piett
Copy link
Owner

Posting this here too just in case:

Following up here @nhoughto @AndrewChubatiuk - would you mind speaking a little more to my question here around the use case on this?

#234 (comment)

@Admiral-Piett
Copy link
Owner

Referring to comment: #234 (comment)

Sorry again @AndrewChubatiuk for the delay, I didn't see this until now. I'm circling back on this to keep it on my radar. So the issue is that you're wanting to call a single instance of goaws from the same host it's on and from a service in a docker network - and you want the responding urls to match the network you're calling from? AKA localhost:4100/... for local, and goaws.com/... for your docker calls?

If so, what's the problem you're having with it NOT doing this? Assuming I'm understanding what the goal is here - it seems odd for goaws to report that it's host based on what the requester is sending in.

@Admiral-Piett
Copy link
Owner

Circling back here @AndrewChubatiuk to see if you've had a chance to think about this.

@AndrewChubatiuk AndrewChubatiuk deleted the get-resource-url-from-host-header branch October 13, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants