-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matmul operator doesn't work on Python 3.4 and less. #18
Comments
using the @ symbol for matrix multiplication was added in python3.5 python3.5 should be listed as a requirement. |
Ahh.. yes! Thanks for pointing that out! I think we can just change the code to not use |
Even after replacing all from p5 import *
File "/Users/arihantparsoya/Documents/p5/p5/__init__.py", line 19, in <module>
from .sketch import *
File "/Users/arihantparsoya/Documents/p5/p5/sketch/__init__.py", line 19, in <module>
from .base import *
File "/Users/arihantparsoya/Documents/p5/p5/sketch/base.py", line 29, in <module>
from ..opengl import renderer
File "/Users/arihantparsoya/Documents/p5/p5/opengl/__init__.py", line 19, in <module>
from .renderer import *
File "/Users/arihantparsoya/Documents/p5/p5/opengl/renderer.py", line 33, in <module>
from ..pmath import matrix
File "/Users/arihantparsoya/Documents/p5/p5/pmath/__init__.py", line 22, in <module>
from .curves import *
File "/Users/arihantparsoya/Documents/p5/p5/pmath/curves.py", line 46
ret_value = func(*new_args, parameter, **kwargs)
^
SyntaxError: only named arguments may follow *expression |
Fixes p5py#18 . Replaced all @ operator with np.dot since @ operator was introduced from python3.5
Hmm.. interesting. I think the new culprit is the tuple unpacking: ret_value = func(*new_args, parameter, **kwargs) We'll have to look through the code to see if this is really needed. If yes, then we add Python 3.5 as a dependency, else re-write it to be compatible for versions less than 3.5. |
I'm running p5 in a pipenv environment, python 3.4
Every sketch I run yields an error in OSX:
The text was updated successfully, but these errors were encountered: