Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update base.py #345

Closed
wants to merge 1 commit into from
Closed

Update base.py #345

wants to merge 1 commit into from

Conversation

kadirgun
Copy link

fix for #340

github-actions[bot]
github-actions bot reviewed Jun 13, 2022
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to p5py

@ziyaointl
Copy link
Member

Hi @kadirgun thanks for submitting a PR to p5py! This is a nice fix in that it's very simple and gets the job done. However, I think I found better solution that doesn't involve adding a special case here: #346.

Let me know your thoughts!

@ziyaointl ziyaointl closed this Jun 14, 2022
@kadirgun kadirgun deleted the patch-1 branch June 14, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kadirgun @ziyaointl