Better imports #21
Merged
Better imports #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The core of this change is to have module names tied to file names, much like Python. As an example, importing "hashmap" looks for a file in a CBCVM_PATH named "hashmap.rbcvm", and the resulting module is called "hashmap". This has some implications: - Since the module name is now the file name, there is no more "module header". - "module" is no longer a keyword. - File names must now be valid identifiers (if they are to be imported). - There is no longer a concept of a "script" which is not module. While at it, I added some logic to avoid reading a module's file if we've already imported it once. Closes #18 Closes #6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See 7e46deb
This does not support importing from directories within a directory in CBCVM_PATH, like
lib/inner/abc.rbcvm, wherelibis in CBCVM_PATH.Some next steps could be to support that, and in the process change it to be more like Python, i.e. using identifier tokens for imports, and dot-separated paths for module hierarchies.