-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Node.js requirements, ESLint, ruleset names; drop Make #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyalaytekin
changed the title
[WIP] Secede and upgrade
[WIP] Update Node.js requirements, ESLint, ruleset names, actions; replace Make with npm
Oct 7, 2023
danyalaytekin
changed the title
[WIP] Update Node.js requirements, ESLint, ruleset names, actions; replace Make with npm
[WIP] Update Node.js requirements, ESLint, ruleset names; drop Make
Oct 7, 2023
19 tasks
danyalaytekin
changed the title
[WIP] Update Node.js requirements, ESLint, ruleset names; drop Make
Update Node.js requirements, ESLint, ruleset names; drop Make
Oct 7, 2023
josebolos
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chefs-kiss.bmp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR drops the makefiles and
make verify
in favour ofnpm test
. While pottering here I had noticed theMakefile.node
's generator, rowanmanning/makefiles/Makefile.node, had been archived in 2017, and its successor project in 2022, so at first I thought I was just going to (1) remove the connection between them and that would be that.Later I realised the flexibility of the remainder of the makefile and didn't think it made sense to keep this flexibility with the connection severed which led to (2) pruning the tasks to match the requirements of this repo's build. With this completed the flexibility of Make itself no longer seemed necessary either leading finally to (3) the replacement of
make verify
withnpm test
.I hope this is all sensible @rowanmanning but please let me know if I've misunderstood something or you had another plan in mind for this repo.
This PR makes the following changes:
^8.51
from^7.27
checkout
(to 4) andsetup-node
(to 3)make verify
withnpm test
master
ormain
, and for PRs targetting any branch, renames job totest
, and deletes comments and names where the file's content is already descriptivees2017
as defaultes2015
's aliases6
,legacy
's aliases5
, and renameslegacy
toes2009
printf >
script and some references to older naming of this packageIt's accompanied by changes to repo settings:
main
frommaster
, part of Rename the 8 default branches tomain
frommaster
org#19Packages
section on the right, because they're in npm not GitHub's registry