Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js requirements, ESLint, ruleset names; drop Make #4

Merged
merged 32 commits into from
Oct 9, 2023

Conversation

danyalaytekin
Copy link
Member

@danyalaytekin danyalaytekin commented Oct 7, 2023

Note

This PR drops the makefiles and make verify in favour of npm test. While pottering here I had noticed the Makefile.node's generator, rowanmanning/makefiles/Makefile.node, had been archived in 2017, and its successor project in 2022, so at first I thought I was just going to (1) remove the connection between them and that would be that.

Later I realised the flexibility of the remainder of the makefile and didn't think it made sense to keep this flexibility with the connection severed which led to (2) pruning the tasks to match the requirements of this repo's build. With this completed the flexibility of Make itself no longer seemed necessary either leading finally to (3) the replacement of make verify with npm test.

I hope this is all sensible @rowanmanning but please let me know if I've misunderstood something or you had another plan in mind for this repo.


This PR makes the following changes:

  1. updates Node.js support to 18 and 20 (current LTS versions) from 12+
  2. upgrades ESLint to ^8.51 from ^7.27
  3. upgrades native Actions checkout (to 4) and setup-node (to 3)
  4. replaces make verify with npm test
  5. sets workflow to trigger on push to either master or main, and for PRs targetting any branch, renames job to test, and deletes comments and names where the file's content is already descriptive
  6. adds migration guide for anticipated v3
  7. sets es2017 as default
  8. drops es2015's alias es6, legacy's alias es5, and renames legacy to es2009
  9. adds lockfile to source control
  10. in the readme fixes a typo in the printf > script and some references to older naming of this package

It's accompanied by changes to repo settings:

@danyalaytekin danyalaytekin self-assigned this Oct 7, 2023
@danyalaytekin danyalaytekin changed the title [WIP] Secede and upgrade [WIP] Update Node.js requirements, ESLint, ruleset names, actions; replace Make with npm Oct 7, 2023
@danyalaytekin danyalaytekin changed the title [WIP] Update Node.js requirements, ESLint, ruleset names, actions; replace Make with npm [WIP] Update Node.js requirements, ESLint, ruleset names; drop Make Oct 7, 2023
@danyalaytekin danyalaytekin changed the title [WIP] Update Node.js requirements, ESLint, ruleset names; drop Make Update Node.js requirements, ESLint, ruleset names; drop Make Oct 7, 2023
@danyalaytekin danyalaytekin marked this pull request as ready for review October 8, 2023 00:07
Copy link
Member

@josebolos josebolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chefs-kiss.bmp

@danyalaytekin danyalaytekin merged commit 1584b0d into main Oct 9, 2023
2 checks passed
@danyalaytekin danyalaytekin deleted the secede-and-upgrade branch October 9, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants