-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade vulnerable dependencies fixing npm audit reports #145
Conversation
Signed-off-by: Sudheesh Singanamalla <sudheesh@cs.washington.edu>
Hi @sudheesh001, thank you for this contribution, and sorry it's taken a while to review it. This repo's assumptions had grown stale, as they had done in a few sibling repos, so I've made a few further changes to bring it closer to passing, such as using |
Aha, I'd reverted |
@danyalaytekin Thank you for following up on this one! This looks great, I'm looking forward to seeing this merged. It does look like github actions indicates a few warnings. Do they need to be resolved before this merge goes through? |
Hi @sudheesh001, the warnings are about the structure of functions, but neither of us have touched the relevant functions here, so the warnings don't indicate a regression. I think we're good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Thanks all!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
co-signed! Thank you very much, @sudheesh001 and @danyalaytekin 🙏
npm audit
shows the result asfound 0 vulnerabilities
Signed-off-by: Sudheesh Singanamalla sudheesh@cs.washington.edu