Fail Action if before-build
or after-build
Return a Non-Zero Exit Code
#214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a similar fashion to the other commands, after running the
before-build
orafter-build
steps we should fail the action if they return with a non-zero exit code.In our setup we use
simplecov
, of which versions after 0.17, produce a coverage report whose format is incompatible withcc-test-reporter
. This produces failures in theafter-build
command, for example:In our specific case, as we use dependabot to update dependencies, we'd like this to fail the action to prevent the dependency from being updated. More generally I think it makes sense for this to fail the action in order to alert the user to fix the issue, although this could potentially be a breaking change for some user's setups.
I suspect this would fix #181