aggregated pending changes #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travis-ci.com replaces travis-ci.org, which is no longer active. Also update the configuration for modern Node versions and to support testing other branches. Signed-off-by: Peter A. Bigot <pab@pabigot.com>
Newer versions of Node.js emit deprecation warnings when using Buffer constructors directly. Replace new Buffer() with Buffer.from. See: https://nodejs.org/en/docs/guides/buffer-constructor-deprecation/ Signed-off-by: Peter A. Bigot <pab@pabigot.com>
Versions 4 and 5 reached maintenance end-of-life over three years ago, shortly after the last major release of this package. As these have known security bugs, and an upcoming enhancement would require extra code to work around lack of offset/length construction arguments if they were to be supported, just drop them. Signed-off-by: Peter A. Bigot <pab@pabigot.com>
A test case added in 2017 used BDD instead of TDD style naming, which worked in older versions of mocha but doesn't now. Replace with consistent naming. Signed-off-by: Peter A. Bigot <pab@pabigot.com>
mocha has a dependency on yargs which only supports actively maintained Node.js releases, which means they outlaw 6 and 8. At the moment they're OK with 10, but only because they haven't released since it reached EOL on 2021-04-30. Drop the versions that won't build in travis as of today. We'll have to test manually to confirm old Node.js release pass. Signed-off-by: Peter A. Bigot <pab@pabigot.com>
* jsdoc ~3.5.5 has security vulnerabilities; use the latest. * mocha ~5.0.5 has security vulnerabilities in dependencies; use the latest. This resolves all current npm audit diagnostics. Signed-off-by: Peter A. Bigot <pab@pabigot.com>
istanbul is no longer maintained; replace it with its successor. Signed-off-by: Peter A. Bigot <pab@pabigot.com>
Convert to const two uses of let that didn't change the variable after it was declared. Signed-off-by: Peter A. Bigot <pab@pabigot.com>
Found by inspection and by updated eslint rules. Signed-off-by: Peter A. Bigot <pab@pabigot.com>
These were pretty old, and didn't need to be locked down quite so hard. Update them, then deal with the fallout including the need to have exceptions for the existing indentation. A subsequent commit might tighten these back up. Signed-off-by: Peter A. Bigot <pab@pabigot.com>
This is recommended to be in the managed sources, so add it. Signed-off-by: Peter A. Bigot <pab@pabigot.com>
|
Changes look good to me |
Thanks; merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates a lot of dependent packages to avoid security issues, unmaintained versions and packages, and fixes style issues that are newly diagnosed. Also updates the Travis integration to the active server.