Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing angular route can cause continuous script errors if a toolbar is shown. #62

Closed
LukeBaulch opened this issue Jan 16, 2014 · 6 comments

Comments

@LukeBaulch
Copy link

When a tooltip is showing and starts to fade away, if you navigate to a different route then a script error occurs. This script occurs in a timeout loop and thus the same script error occurs every X milliseconds.

I'm assuming this is due to the fade-out animation trying to continue to fade after the angular routing has already removed the toolbar element from the dom.

I've made a JS Fiddle that demonstrates this.

To see whether this was a highcharts issue or a highcharts-ng issue, I removed the directive and used the typical Highcharts.chart() function and this error did not occur. It seems that perhaps highcharts-ng might need to handle this scenario.

If you need more info, please ask. The JS Fiddle has some reproduction steps.

@pablojim
Copy link
Owner

Interesting thanks for reporting this. Do have a fiddle for just using a vanilla highcharts object as you mentioned?

@LukeBaulch
Copy link
Author

I don't but it would be very easy to do. If you can wait until tomorrow,
then I can create one. It would take all of 2 minutes to swap out the
directive/tag and call the highcharts function.
On 16 Jan 2014 19:48, "Barry Fitzgerald" notifications@github.com wrote:

Interesting thanks for reporting this. Do have a fiddle for just using a
vanilla highcharts object as you mentioned?


Reply to this email directly or view it on GitHubhttps://github.com//issues/62#issuecomment-32451059
.

@LukeBaulch
Copy link
Author

Here is a JS Fiddle without the highcharts-ng directive.
You will find that you won't be able to cause the same issue as mentioned above in this example without the directive.

@pablojim
Copy link
Owner

Raised: highcharts/highcharts#2616

@pablojim
Copy link
Owner

Luke could you test the recent fix in Highcharts?

@LukeBaulch
Copy link
Author

Looks like this issue has been resolved now.
I used the previous JSFiddle and swapped out the highcharts references with the new code.
JSFiddle of working version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants