Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify how to get data from the core #49

Closed
pacdiv opened this issue Oct 4, 2019 · 1 comment
Closed

Simplify how to get data from the core #49

pacdiv opened this issue Oct 4, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@pacdiv
Copy link
Owner

pacdiv commented Oct 4, 2019

Do you want to request a feature or report a bug?
Feature.

What is the current behavior?
Currently, the Playground component must call the core's getChunks and getRegexChunks methods after every condition add/update/delete.

What is the expected behavior?
As a maintainer, I should be able to call a function allowing to get both chunks and regexChunks, especially since regexChunks must stay synchronized with every change on chunks (this is also the case for capturedChunks, which only contains captures stored in chunks).
@pacdiv pacdiv added the enhancement New feature or request label Oct 4, 2019
@pacdiv pacdiv changed the title Simplify how the core currently works Simplify how to get data from the core Oct 4, 2019
@pacdiv pacdiv mentioned this issue Oct 4, 2019
Merged
@pacdiv
Copy link
Owner Author

pacdiv commented Oct 4, 2019

Solved by the pull request #51.

@pacdiv pacdiv closed this as completed Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pacdiv