Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

objstore: move healthcheck registration into client creation #235

Closed
daemonfire300 opened this issue Oct 21, 2020 · 0 comments · Fixed by #236
Closed

objstore: move healthcheck registration into client creation #235

daemonfire300 opened this issue Oct 21, 2020 · 0 comments · Fixed by #236
Assignees
@daemonfire300
Labels
EST::Hours Effort between 0 and 7 hours S::In Progress Issue is being worked on by at least one person T::Maintainance Refactoring; Better UX/UI; DevOps; Infrastructure; missing documentation

Comments

@daemonfire300
Copy link
Contributor

Motivation

Do not register healthchecks if the package is simply being imported but the client not necessarily used, i.e., move them out of the init() method into the client creation.
@daemonfire300 daemonfire300 added EST::Hours Effort between 0 and 7 hours S::In Progress Issue is being worked on by at least one person T::Maintainance Refactoring; Better UX/UI; DevOps; Infrastructure; missing documentation labels Oct 21, 2020
@daemonfire300 daemonfire300 self-assigned this Oct 21, 2020
daemonfire300 added a commit that referenced this issue Oct 21, 2020
@daemonfire300
Objstore: Remove healthchecks from init() and wrap in sync.Once #235
de4e3cb
daemonfire300 added a commit that referenced this issue Oct 21, 2020
@daemonfire300
Objstore: Remove healthchecks from init() and wrap in sync.Once #235
9938744
@daemonfire300 daemonfire300 mentioned this issue Oct 21, 2020
Merged
daemonfire300 added a commit that referenced this issue Oct 22, 2020
@daemonfire300
Objstore: Remove healthchecks from init() and wrap in sync.Once #235
f9b3396
daemonfire300 added a commit that referenced this issue Oct 22, 2020
@daemonfire300
Merge pull request #236 from pace/235-objstore-healthchecks
6e4f4d1 
Objstore: Remove healthchecks from init() and wrap in sync.Once #235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daemonfire300 daemonfire300

Labels
EST::Hours Effort between 0 and 7 hours S::In Progress Issue is being worked on by at least one person T::Maintainance Refactoring; Better UX/UI; DevOps; Infrastructure; missing documentation
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Objstore: Remove healthchecks from init() and wrap in sync.Once #235 pace/bricks
1 participant
@daemonfire300