Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc bug fixes + Allow sleuth_prep to process just one sample #114

Merged
merged 4 commits into from
Jun 2, 2017

Conversation

warrenmcg
Copy link
Collaborator

Hi @pimentel,

First of all, I noticed to small errors in my contributions to sleuth_prep that will result in problems for users:

  • A typo caused an error if factor levels were supposed to be dropped.
  • If there is an error in one of the later mclapply jobs, but the first job is successful, then the code will continue as if everything is ok and this may result in a cryptic downstream error for the user. This updated code checks all of the jobs to make sure they were all successful, and throws an error if at least one of them failed.

To expand on pull_request #92, I went ahead and updated the code to prevent errors due to a one-column data.frame being converted to a vector using drop = FALSE. I also added a warning if the user supplies one sample but also a model, since the modeling aspects of sleuth don't work when you only have one sample. I have confirmed this new code works by running the small_test_data Kallisto file, which I'm incorporating into some new tests (separate pull request).

@pimentel pimentel merged commit 6f02774 into pachterlab:devel Jun 2, 2017
@pimentel
Copy link
Collaborator

pimentel commented Jun 2, 2017

right on, thanks yet again!

I've been thinking about allowing 1 sample analysis for a while but have wanted to put safeguards in. I think the warning is sufficient for now. we will probably expand it later.

best,

harold

@warrenmcg warrenmcg deleted the issue92 branch June 3, 2017 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants