unify external command invocation #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations! The build has finished successfully. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
lachmanfrantisek
approved these changes
Jul 9, 2019
| else: | ||
| proc = subprocess.run( | ||
| ["git", "clone", repo_ssh_url], stderr=subprocess.PIPE, timeout=CLONE_TIMEOUT | ||
| ) |
Closed
jpopelka
reviewed
Jul 9, 2019
| ) | ||
| output = proc.stderr.read().decode() | ||
| logger.debug("Clone exited with {} and output: {}".format(proc.returncode, output)) | ||
| if "does not exist yet" in output: |
There was a problem hiding this comment.
I don't see the yet in the failed git clone output
| proc = subprocess.run( | ||
| ["git", "clone", repo_ssh_url], stderr=subprocess.PIPE, timeout=CLONE_TIMEOUT | ||
| ) | ||
| output = proc.stderr.read().decode() |
There was a problem hiding this comment.
Suggested change
| output = proc.stderr.read().decode() | |
| output = proc.stderr.decode() |
since AttributeError: 'bytes' object has no attribute 'read'
|
@jpopelka sorry for the quick merge... @lbarcziova Can you please fix the suggestions by @jpopelka in the second pull-request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33