Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more docs on permissions in downstream jobs #851

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

majamassarini
Copy link
Member

No description provided.

Copy link
Contributor

Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Maja, really nicelly written, just few comments

Comment on lines +15 to +18

Packit provides an overview of its own updates [here](https://dashboard.packit.dev/jobs/bodhi-updates).

You can also utilise
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating this!

docs/fedora-releases-guide/index.md Outdated Show resolved Hide resolved
docs/fedora-releases-guide/index.md Outdated Show resolved Hide resolved
docs/fedora-releases-guide/index.md Outdated Show resolved Hide resolved
docs/fedora-releases-guide/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

Copy link
Contributor


# Permission Handling

The downstream automation is a chain of jobs: propose downstream/pull from upstream -> koji build -> bodhi update.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The downstream automation is a chain of jobs: propose downstream/pull from upstream -> koji build -> bodhi update.
The downstream automation is a pipeline of jobs: propose_downstream/pull_from_upstream -> koji_build -> bodhi_update.

Technically, the first part is optional, one can start a pipeline with a direct push. Should we mention that somehow?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about something like this:

Suggested change
The downstream automation is a chain of jobs: propose downstream/pull from upstream -> koji build -> bodhi update.
The downstream automation is a pipeline of jobs: propose_downstream/pull_from_upstream/your-own commits -> koji_build -> bodhi_update.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it could also be Packit commits pushed by a user 🙂
Actually, it should look more like this:
propose_downstream/pull_from_upstream -> Packit PR merge/dist-git push -> koji_build -> bodhi_update.

Copy link
Member

@nforro nforro Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or perhaps this is more accurate:

propose_downstream/pull_from_upstream -> Packit PR merge -> koji_build -> bodhi_update
PR merge/dist-git push -> koji_build -> bodhi_update

Copy link
Contributor

Copy link
Contributor

Co-authored-by: Laura Barcziová <49026743+lbarcziova@users.noreply.github.com>
Co-authored-by: Nikola Forró <nforro@redhat.com>
Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

docs/fedora-releases-guide/index.md Outdated Show resolved Hide resolved
Co-authored-by: Nikola Forró <nforro@redhat.com>
@majamassarini majamassarini added the mergeit When set, zuul wil gate and merge the PR. label Mar 15, 2024
Copy link
Contributor

@majamassarini majamassarini merged commit 17c9117 into packit:main Mar 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants