Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: freshfetch-git #6136

Merged
merged 12 commits into from
Jul 4, 2024
Merged

add: freshfetch-git #6136

merged 12 commits into from
Jul 4, 2024

Conversation

pythoncrazy
Copy link
Contributor

I want to add freshfetch-git, for some reason it errors out on my ARM testing system, but works across the ~5 Ubuntu based distros running x86_64. If you have any advice/fixes, they would be very much appreciated.

@github-actions github-actions bot added the Package Add Use this to request a package to be added label Jun 17, 2024
@Elsie19 Elsie19 linked an issue Jun 19, 2024 that may be closed by this pull request
@Elsie19
Copy link
Member

Elsie19 commented Jun 19, 2024

What error is is on ARM?

@pythoncrazy
Copy link
Contributor Author

Some error with the faccess crate, I am not sure how to fix it:

    --> /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/faccess-0.2.3/src/lib.rs:95:36
     |
95   |             if faccessat(AT_FDCWD, path.as_ptr() as *const i8, mode, AT_EACCESS) == 0 {
     |                ---------           ^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `*const u8`, found `*const i8`
     |                |
     |                arguments to this function are incorrect
     |
     = note: expected raw pointer `*const u8`
                found raw pointer `*const i8`
note: function defined here
    --> /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/libc-0.2.104/src/unix/linux_like/linux/mod.rs:3738:12
     |
3738 |     pub fn faccessat(
     |            ^^^^^^^^^

For more information about this error, try `rustc --explain E0308`.
error: could not compile `faccess` (lib) due to previous error

external_connection="true"

build() {
cd "${_archive}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stop using _archive, use "${gives}" or "freshfetch".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, will do

packages/freshfetch-git/freshfetch-git.pacscript Outdated Show resolved Hide resolved
packages/freshfetch-git/freshfetch-git.pacscript Outdated Show resolved Hide resolved
pythoncrazy and others added 2 commits July 3, 2024 14:12
Used single quotes

Co-authored-by: Elsie <hwengerstickel@protonmail.com>
Used the locked (in) version for cargo build.

Co-authored-by: Elsie <hwengerstickel@protonmail.com>
@Elsie19 Elsie19 merged commit 34c4b99 into pacstall:master Jul 4, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package Add Use this to request a package to be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PacReq: <freshfetch>
3 participants