Pact PHP - Support for V3 / V4 + Plugins Via FFI

[YOU54F]

Pact PHP - Support for V3 / V4 + Plugins Via FFI

What is the current status

Pact-PHP does not currently support v3+ features of the rust core, in the mainline branch.

V3+ features are now available for beta testing in ffi branch, in a view to stabilise and release into the mainline.

We would <3 your support

How can I test this today

Anyone can start testing pact-php with pact_ffi code by updating their composer.json

"pact-foundation/pact-php": "10.0.0-alpha1"

• Migration Guide:- https://github.com/pact-foundation/pact-php/blob/ffi/UPGRADE-10.0.md
• 10.0.0-alpha1 release notes

PR's which made up this release

NB:- Although marked as closed, they have been consolidated and merged into a single branch under #323

• Consumer Use Rust FFI #3: Consumer #280
• Message Consumer Use Rust FFI #4: Message Consumer #281
• Provider Use Rust FFI #5: Provider #282
• Stub Server Use Rust FFI #6: Stub Server #283
• Test stub server health check #294
• Use Rust FFI #6.1: Remove stub server health check #295
• Use Rust FFI #6.1: Remove stub server health check #295
• Use Rust FFI #6.2: Move endpoint config #296
• Use Rust FFI #7.1: Stub server random port #297
• Use Rust FFI #10: Remove pact broker #302
• Use Rust FFI #11: Allow set content type #303
• Use Rust FFI #3.6: Add generators and matchers #310

How can I submit feedback

All feedback is gratefully received, positive feedback is great, as it allows us to ascertain how well the package is doing for users. Constructive criticism is okay too, but see the next section

• Reply in this pull request
• Raise a new issue, clearly stating you are using the ffi branch

How can I contribute

If you want to help improve Pact-PHP, read the DEVELOPING.md documentation, fork the repo and have a play!

[tienvx]

I created release/9.x branch from current master branch for future PRs that target standalone ruby.

[Lewiscowles1986]

Most of the points I'm calling out here have been called out before, so I don't think we should block this great performance, functionality and stability win.

• I've skipped reviewing all tests and compatibility; PR is where they should have been reviewed and I've done my best there
• Using checks as a guide as well (this is so much more stable than PACT prior)
• Reviewed the patch https://patch-diff.githubusercontent.com/raw/pact-foundation/pact-php/pull/326.patch with both manual review and automated tools looking for anything that could ruin anyones day.

1. Suggestion added for release mentioning 10.x (is this 9.x or 10.x?) adjust as appropriate
2. Comment on moving pieces folks might need a guided hand on

Fantastic Work @tienvx 🎉

This might take me some time to finish reviewing, but I'm over half-way through in first sitting.

[JP-Ellis]

Just wanted to say, absolutely amazing work @tienvx!! And thank you @Lewiscowles1986 for helping with the review and providing feedback.

This is a behemoth of a PR, and thankfully a lot of the work has been reviewed in previous PRs.

Looking forward to this being merged, and Pact PHP v10 being made widely available!

[mefellows]

I second third this. Amazing work Tien - painstakingly breaking it into who knows how many PRs, and then incrementally improving them with more tests, documentation etc.

Seeing it all in one place like this shows the enormity of what has been done.

Lewis - you deserve a lot of credit, I've seen how quickly you've been reviewing and providing feedback on these PRs.

Tien might be the hero, but you're the Robin to his Batman👏 .

Can't wait to see this in action!

[YOU54F]

Amazing work @tienvx! I need to go through the upgrade guide/readme again and check it is still relevant as there has been a fair few changes, and also test against a few of the public projects I used, to show the migration path when I last gave it a spin

• feat: pact-php ffi-next upgrade from 9.x (ruby core) to rust core YOU54F/pact-testing#1
• feat: pact-php ffi-next upgrade from 9.x (ruby core) to rust core YOU54F/015-pact-http-producer-php#1
• feat: pact-php ffi-next upgrade from 9.x (ruby core) to rust core YOU54F/014-pact-http-consumer-php#1
• feat: pact-php ffi-next upgrade from 9.x (ruby core) to rust core YOU54F/simple-pact#1

[Lewiscowles1986]

@YOU54F https://github.com/Lewiscowles1986/pact-testing/actions/runs/8291625745/job/22691646516 which is a fork of the first you showed, says this works

• deleted the lockfile to pull from ffi branch and observed improved readability of output
• Experimented until landing on --testdox style rather than dots default

https://github.com/Lewiscowles1986/015-pact-http-producer-php/actions/runs/8291769679 Also runs a producer example (and made me hate GitHub choices 🥲 ), it's the 015-pact-http-producer-php

https://github.com/Lewiscowles1986/014-pact-http-consumer-php/actions/runs/8291853993 passes, although Guzzle had to update

[Lewiscowles1986]

LGTM