Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add All interactions iterator #451

Open
2 of 3 tasks
JP-Ellis opened this issue Nov 3, 2023 · 0 comments
Open
2 of 3 tasks

Add All interactions iterator #451

JP-Ellis opened this issue Nov 3, 2023 · 0 comments
Labels
area:upstream Relating to an upstream component area:v3 Relating to the pact.v3 module difficulty:easy A simple task appropriate for newcomers to the codebase type:feature New feature

Comments

@JP-Ellis
Copy link
Contributor

JP-Ellis commented Nov 3, 2023

Have you read the Contributing Guidelines on issues?

Description

Implement the pact.interactions("All") method. While the upstream Pact core library supports this, the method requires passing a point to the Pact directly, instead of using the Pact handle. See:

We must wait for the upstream library to either:

  • Provide a way to get the underlying pointer to the Pact from a PactHandle; or,
  • Implement an equivalent to pact_model_interaction_iterator that takes in a PactHandle.

Has this been requested on Canny?

No response

Motivation

It is a feature which is partially supported upstream, and would not require too much work to get working hopefully.

Have you tried building it?

No response

Self-service

  • I'd be willing to contribute this feature to Pact Python myself.
@JP-Ellis JP-Ellis added type:feature New feature area:upstream Relating to an upstream component difficulty:easy A simple task appropriate for newcomers to the codebase area:v3 Relating to the pact.v3 module labels Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:upstream Relating to an upstream component area:v3 Relating to the pact.v3 module difficulty:easy A simple task appropriate for newcomers to the codebase type:feature New feature
Projects
Status: 📝 Backlog
Development

No branches or pull requests

1 participant