Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to be able to match 'pact-specification' as well as 'pactSpecification' for versioning information #62

Closed
psbanka opened this issue Oct 18, 2018 · 2 comments

Comments

@psbanka
Copy link

psbanka commented Oct 18, 2018

The Ruby parser for a pact file does not properly pull version information from a pact file generated from ember-cli-pact. That project creates a meta tag along these lines:

  "metadata": {
    "pact-specification": {
      "version": "3.0.0"
    }
  },

However, the http_consumer_contract-parser.rb file only respects the key, "pactSpecification" relevant code here. Looking at the JSON Schema file here, it appears that both "pact-specification" and "pactSpecification" are acceptable keys. Therefore it seems to me that this library should support either?

@bethesque
Copy link
Member

Please use pactSpecification.

@psbanka
Copy link
Author

psbanka commented Oct 22, 2018

Will do; thanks.

@psbanka psbanka closed this as completed Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants