Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating wasmer, using new set_tunable function #25

Closed
wants to merge 1 commit into from

Conversation

kehiy
Copy link
Contributor

@kehiy kehiy commented Jan 1, 2024

Description

The current wasmer version doesn't support the new_with_tubables function and it's deprecated. This PR will fix that issue by updating the wasmer crate.

Checklist

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • CHANGELOG is updated.

@kehiy kehiy requested a review from b00f January 1, 2024 19:12
@kehiy kehiy self-assigned this Jan 1, 2024
@b00f
Copy link
Collaborator

b00f commented Jan 2, 2024

@kehiy tests has failed!

@kehiy
Copy link
Contributor Author

kehiy commented Jan 2, 2024

@b00f

I thought they are the tests which is already broken. some of tests are broken as we removed some wasm files in test contract, I tried to re-compile them and fix it, but that seems the commands in test contract readme are broken also.

I'll check and fix new tests which are broken and push new changes soon.

@kehiy kehiy closed this May 6, 2024
@kehiy kehiy deleted the hotfix/brokenTest branch May 6, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants