-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add provide method #97
base: master
Are you sure you want to change the base?
Conversation
…e-repository-module, ngx-http-repository-module. Methods forRoot marked as deprecated. Replace forRoot uses by provide method.
projects/ngx-firestore-repository/src/lib/ngx-firestore-repository.module.spec.ts
Show resolved
Hide resolved
@@ -162,7 +162,7 @@ describe('NgxRepositoryService', () => { | |||
expect(repository).toEqual('Book - MyBookRepository'); | |||
}); | |||
|
|||
it('should throw error when multiple builders and repository type is not configured', () => { | |||
it('should throw error when multiple builders and : type is not configured', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
.run/build_all.run.xml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert ce fichier
.run/lint.run.xml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert ce fichier
projects/ngx-firestore-repository/src/lib/ngx-firestore-repository.module.spec.ts
Show resolved
Hide resolved
@@ -21,10 +21,12 @@ export function initializeRepository<T>(bookImpl: Type<T>, providers: any[] = [] | |||
|
|||
TestBed.configureTestingModule({ | |||
imports: [ | |||
NgxRepositoryModule.forRoot(), | |||
NgxHttpRepositoryModule.forRoot() | |||
NgxRepositoryModule, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
du coup il faut enlever les imports de module et juste utiliser le provide
…vice + removed weird test
Add provide method for ngx-repository-module, ngx-firestore-repository-module, ngx-http-repository-module.
Methods forRoot marked as deprecated.
Replace forRoot uses by provide method.