Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog Tutorial Improvements #119

Closed
adam12 opened this issue Nov 21, 2016 · 2 comments
Closed

Blog Tutorial Improvements #119

adam12 opened this issue Nov 21, 2016 · 2 comments
Assignees

Comments

@adam12
Copy link
Collaborator

adam12 commented Nov 21, 2016

I ran through the blog tutorial to verify accuracy, and I made a few observations that could translate into improvements.

Remove: Section on updating database configuration manually from Heroku DATABASE_URL variable

As this step technically isn't needed to complete the tutorial, I can't help but wonder if it should just be removed. As the values won't match up to what the user would be seeing, I wonder if it might be a source of confusion to newcomers.

Remove: Addition to dependency_paths

Looks like default_dependency_paths already includes this path, allowing us to remove this step.

Consistency: Settle on bundle exec rake or padrino rake

I've never seen padrino rake until following the tutorial. Maybe someone else can advise whether one or the other is better suited.

Remove: Tweak to db/seeds.rb

I was prompted for a username and password when seeding. I think this can be safely removed.


I'm willing to take care of these items, barring no objections from the core team.

@nesquena
Copy link
Member

All of these changes look correct to me and would be welcome updates. cc @wikimatze @ujifgc for any additional feedback

@wikimatze
Copy link
Member

Feel free to update the article, we will review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants