Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added rudimentary style support to nodes #2

Merged
merged 2 commits into from
Mar 8, 2014
Merged

Conversation

rwarren
Copy link
Contributor

@rwarren rwarren commented Mar 3, 2014

Nothing fancy here... just adding a string passthrough for the style attribute for nodes.

example:

dotter.add_node("foo", shape="box", style="diagonals, filled, bold")

@myusuf3
Copy link

myusuf3 commented Mar 3, 2014

💯

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.13%) when pulling c429bb8 on rwarren:master into 195ee5c on paetzke:master.

@paetzke
Copy link
Owner

paetzke commented Mar 3, 2014

Great!

But I think I would like it better this way.

class Style:
    Diagonals = 'diagonals'
    Filled = 'filled'
    Bold = 'bold'

dotter.add_node("foo", shape="box", styles=["diagonals", "filled", "bold"])

@rwarren
Copy link
Contributor Author

rwarren commented Mar 3, 2014

Agreed... but then fillcolor (and its ilk) become more annoying to deal
with, so I had just gone with a string passthrough.

http://www.graphviz.org/doc/info/shapes.html#d:style

Unit tests would also be good and I'm looking at that right now.

And so my super-quick hack I thought I may as well share begins to creep...
:)

Russ

On Mon, Mar 3, 2014 at 3:42 PM, Friedrich Paetzke
notifications@github.comwrote:

Great!

But I think I would like it better this way.

class Style:
Diagonals = 'diagonals'
Filled = 'filled'
Bold = 'bold'

dotter.add_node("foo", shape="box", styles=["diagonals", "filled", "bold"])

Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-36556964
.

Russell Warren
Perspexis Technologies Inc.

This information is confidential and intended solely for the use of the
individual or entity to whom it is addressed.
If you have received this email in error, please notify the sender
immediately.

@rwarren
Copy link
Contributor Author

rwarren commented Mar 4, 2014

Ok... I committed a change to match what was mentioned. I also added a
crude unit test.

Note that one of your unit tests is already failing on my machine. I did
not investigate or fix this issue, but here is my output:
http://bpaste.net/raw/DNa6Mfm03EHU7sVXsm5h/

On Mon, Mar 3, 2014 at 3:45 PM, Russell Warren russ@perspexis.com wrote:

Agreed... but then fillcolor (and its ilk) become more annoying to deal
with, so I had just gone with a string passthrough.

http://www.graphviz.org/doc/info/shapes.html#d:style

Unit tests would also be good and I'm looking at that right now.

And so my super-quick hack I thought I may as well share begins to
creep... :)

Russ

On Mon, Mar 3, 2014 at 3:42 PM, Friedrich Paetzke <
notifications@github.com> wrote:

Great!

But I think I would like it better this way.

class Style:
Diagonals = 'diagonals'
Filled = 'filled'
Bold = 'bold'

dotter.add_node("foo", shape="box", styles=["diagonals", "filled", "bold"])

Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-36556964
.

Russell Warren
Perspexis Technologies Inc.

This information is confidential and intended solely for the use of the
individual or entity to whom it is addressed.
If you have received this email in error, please notify the sender
immediately.

Russell Warren
Perspexis Technologies Inc.

This information is confidential and intended solely for the use of the
individual or entity to whom it is addressed.
If you have received this email in error, please notify the sender
immediately.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling af07611 on rwarren:master into 195ee5c on paetzke:master.

@paetzke paetzke merged commit af07611 into paetzke:master Mar 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants