Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mask: add maskEngine configuration #50

Merged
merged 1 commit into from
Jul 18, 2018
Merged

mask: add maskEngine configuration #50

merged 1 commit into from
Jul 18, 2018

Conversation

evaporei
Copy link
Contributor

Escriba used to use only the mask library iron-mask.
Now it accepts a maskEngine parameter which accepts
both iron-mask and mask-json packages. If none is
provided, iron-mask will be used to keep the same
interface and behaviour.

Co-authored-by: igorantun igor.antun@pagar.me

Escriba used to use only the mask library `iron-mask`.
Now it accepts a `maskEngine` parameter which accepts
both `iron-mask` and `mask-json` packages. If none is
provided, `iron-mask` will be used to keep the same
interface and behaviour.

Co-authored-by: igorantun <igor.antun@pagar.me>
@coveralls
Copy link

Coverage Status

Coverage decreased (-5.9%) to 86.869% when pulling 63af0f6 on add-mask-engine into f325a26 on master.

Copy link
Contributor

@vitorabner vitorabner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! :shipit:

@evaporei evaporei merged commit 21c07f8 into master Jul 18, 2018
@evaporei evaporei deleted the add-mask-engine branch July 18, 2018 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants