Fixing subscrition by card_hash #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petriuslima
changed the title
petriuslima
changed the title
devdrops
suggested changes
Feb 21, 2017
| parent::getPayload() | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
@petriuslima adicione o dockblock para o método 😉
|
@devdrops Adicionado! |
| return $phoneMock; | ||
| } | ||
|
|
||
| private function defaultPayloadWithoutCardInfo() |
There was a problem hiding this comment.
@petriuslima esse nome ficaria mais claro se especificasse se ele obtém ou define o payload.
There was a problem hiding this comment.
@ricardotulio Feito!
| public function mustPayloadBeCorrect() | ||
| const CARD_HASH = 'FC1mH7XLFU5fjPAzDsP0ogeAQh3qXRpHzkIrgDz64lITBUGwio67zm'; | ||
|
|
||
| private function getConfiguredPlanForPayloadTest() |
There was a problem hiding this comment.
@petriuslima alguns métodos para criação dos mocks tem a palavra mock e outros não. O que acha de definirmos um padrão?
There was a problem hiding this comment.
@ricardotulio Padronizado para conter a palavra mock.
devdrops
approved these changes
Feb 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing subscrition by card_hash as described in #126.