Replace ifconfig with ip #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did the merge but noticed line 74 was not changed. Can you take a look at
that line. Thanks Claude ...
…On Tue, Mar 29, 2022 at 12:10 PM Alyetama ***@***.***> wrote:
ifconfig was deprecated in favor of ip and is no longer shipped by
default in the Raspberry Pi OS. ./menubox will raise a non-fatal error
every time I use it because I don't have ifconfig installed on my system.
This PR replaces ifconfig with ip as a proposed solution (as opposed to
of making changes to the installation part),.
------------------------------
You can view, comment on, or merge this pull request online at:
#127
Commit Summary
- 84573e3
<84573e3>
Replace ifconfig with ip
File Changes
(1 file <https://github.com/pageauc/pi-timolo/pull/127/files>)
- *M* source/menubox.sh
<https://github.com/pageauc/pi-timolo/pull/127/files#diff-e29909a7efc5853c265189a267b58423e39dd3c48916801246a3bb5a0b6fd154>
(2)
Patch Links:
- https://github.com/pageauc/pi-timolo/pull/127.patch
- https://github.com/pageauc/pi-timolo/pull/127.diff
—
Reply to this email directly, view it on GitHub
<#127>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNPKZAQPGF5COLVPM4RUW3VCM2QXANCNFSM5R7CVIGA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
YouTube Channel at https://www.youtube.com/user/pageaucp
<http://www.youtube.com/user/pageaucp>
GitHub Repository at https://github.com/pageauc
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ifconfigwas deprecated in favor ofipand is no longer shipped by default in the Raspberry Pi OS../menuboxwill raise a non-fatal error every time I use it because I don't haveifconfiginstalled on my system. This PR replacesifconfigwithipas a proposed solution (as opposed to making changes to the installation part).