Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent_count metric should include first resource in resource label #26

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

igno
Copy link
Contributor

@igno igno commented Jan 17, 2023

In order to filter agent_count metric on the first resource that the agent has the resource label needs to be present.

This will allow for queries like:

sum(agent_count{agent_config_state="Enabled",build_state="Building",resource="my-resource"})

There's an assumption here that the agents only have one resource.

In order to filter agent_count metric on the first resource that the
agent has the resource label needs to be present.

This will allow for queries like:
```
sum(agent_count{agent_config_state="Enabled",build_state="Building",resource="my-resource"})
```

There's an assumption here that the agents only have one resource.
@igno igno requested a review from oscr January 17, 2023 09:25
Copy link
Contributor

@oscr oscr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌳

@igno igno merged commit 342c4bc into master Jan 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the agent-count-resource-label branch January 17, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants