Change metric agent_count into agent_state #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igno
approved these changes
Apr 11, 2019
| @@ -7,7 +7,7 @@ import ( | |||
| "strings" | |||
| "time" | |||
|
|
|||
| "github.com/ashwanthkumar/go-gocd" | |||
| gocd "github.com/ashwanthkumar/go-gocd" | |||
There was a problem hiding this comment.
Any reason why this is needed?
|
@pagero/hawk Closing as it hasn't been merged for 4 months |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Renamed the metric
agent_countintoagent_state, and added the agent's hostname asagentlabel.Why:
We noticed that the
agent_countgauge wasn't so helpful, and we were also missing an ability to see which specific agents (= "hostnames") that had different "build state", "agent state", and "config state".Thus, adding hostname ("agent") as a label means the gauge is split by actual agent, and a more detailed view of each of the agents is available.
Instead of just a count of how many are in different states, now we can see which ones.
Notes:
To count the total number of agents...
...before:
...after:
This change isn't backwards compatible for this particular metric, so we might want to bump the minor version after merging this change.