Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more specific naming rules #5

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Add more specific naming rules #5

merged 1 commit into from
Apr 14, 2021

Conversation

balanza
Copy link
Contributor

@balanza balanza commented Apr 13, 2021

We refine @typescript-eslint/naming-convention so that it will cope with our current codebase standards. For further explanation, see docs.

@pagopa-github-bot
Copy link
Collaborator

Warnings
⚠️ Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS against 8e74633

@balanza balanza mentioned this pull request Apr 13, 2021
Merged
6 tasks
BurnedMarshal
BurnedMarshal approved these changes Apr 14, 2021
View reviewed changes
Copy link
Collaborator

@BurnedMarshal BurnedMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balanza balanza merged commit d70349e into master Apr 14, 2021
@balanza balanza deleted the refine-naming-convention branch April 14, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurnedMarshal BurnedMarshal BurnedMarshal approved these changes

@Undermaken Undermaken Undermaken approved these changes

@AleDore AleDore Awaiting requested review from AleDore

@cloudify cloudify Awaiting requested review from cloudify

@francescopersico francescopersico Awaiting requested review from francescopersico

@gunzip gunzip Awaiting requested review from gunzip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@balanza @pagopa-github-bot @Undermaken @BurnedMarshal