chore(IT Wallet): [SIW-722] Add verifyAndParseCredential phase to credential issuing #5310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagopa-github-bot
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## bundle/it-wallet #5310 +/- ##
====================================================
- Coverage 46.36% 46.36% -0.01%
====================================================
Files 1637 1637
Lines 33976 33982 +6
Branches 8237 8241 +4
====================================================
+ Hits 15754 15755 +1
- Misses 18171 18176 +5
Partials 51 51
Continue to review full report in Codecov by Sentry.
|
|
@LazyAfternoons this PR can be reviewed? What's missing? |
It needs this fix in |
hevelius
added a commit
that referenced
this pull request
Dec 18, 2023
## Short description Depends on #5310, #5315 and #5321. This PR introduces a refactors in how we render the claims list. The general idea behind this refactor is that we are parsing the `unknown` value of a claim with io-ts decoders to known which kind of claim we are manipulating, thus rendering an appropriate component to display it. ## List of changes proposed in this pull request - Defines a set of decoders for our claims; - Adds a `itwCredentialClaim.tsx` which decodes the claim and renders the appropriate component; - Align `ItwCredentialClaimsList.tsx` to the new changes; - Moves every claim related util to `ItwClaimsUtils`. ## How to test Test the available credentials, each claim should be render properly formatted. --------- Co-authored-by: Mario Perrotta <mario.perrotta@pagopa.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Depends on this PR.
This PR introduces the
verifyAndParseCredentialphase to the credential issuing flow.List of changes proposed in this pull request
ItwIssuanceSaga.tswith the libraryverifyAndParseCredentialfunction which already returns a Record of claims;ItwCredentialClaimsList.tsxto get the claims from the new Record structure. There's no need to use thecredentialConfigurationSchemaanymore.How to test
Reset the wallet. Test a credential issuing flow, the claims should be displayed just as before.