chore(IT Wallet): [SIW-740] Refactor claims list #5321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 11, 2023
pagopa-github-bot
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## bundle/it-wallet #5321 +/- ##
====================================================
- Coverage 46.36% 46.36% -0.01%
====================================================
Files 1637 1638 +1
Lines 33976 34010 +34
Branches 8237 8245 +8
====================================================
+ Hits 15754 15769 +15
- Misses 18171 18190 +19
Partials 51 51
Continue to review full report in Codecov by Sentry.
|
LazyAfternoons
added a commit
that referenced
this pull request
Dec 14, 2023
## Short description This PR introduces the health card issuance issuance. Note: there's an issue with the place of birth claim which is going to addressed in a separate issue ([SIW-681](https://pagopa.atlassian.net/jira/software/projects/SIW/boards/222?selectedIssue=SIW-740)). Since the component which renders the claims list needs a substantial refactor I decided to leave it out of the scope of this PR. See #5321. ## List of changes proposed in this pull request - Updates the mock data required to obtain a display the credential; - Rename the card front asset according to the name of the credential. ## How to test With an valid wallet test the health card issuance flow. [SIW-681]: https://pagopa.atlassian.net/browse/SIW-681?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
LazyAfternoons
added a commit
that referenced
this pull request
Dec 14, 2023
## Short description This PR adds the mobile driving license issuing. Some claims might not be rendered properly. Since the component which renders the claims list needs a substantial refactor I decided to leave it out of the scope of this PR. See #5321. ## List of changes proposed in this pull request - Updates the mock data required to obtain and display the credential. ## How to test Test the mDL issuing flow.
…-refactor-claims-list
|
🎉 All dependencies have been resolved ! |
hevelius
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Depends on #5310, #5315 and #5321.
This PR introduces a refactors in how we render the claims list. The general idea behind this refactor is that we are parsing the
unknownvalue of a claim with io-ts decoders to known which kind of claim we are manipulating, thus rendering an appropriate component to display it.List of changes proposed in this pull request
itwCredentialClaim.tsxwhich decodes the claim and renders the appropriate component;ItwCredentialClaimsList.tsxto the new changes;ItwClaimsUtils.How to test
Test the available credentials, each claim should be render properly formatted.