-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(IT Wallet): [SIW-681] Health card issuance #5315
feat(IT Wallet): [SIW-681] Health card issuance #5315
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## bundle/it-wallet #5315 +/- ##
====================================================
- Coverage 46.36% 46.36% -0.01%
====================================================
Files 1637 1637
Lines 33976 33978 +2
Branches 8237 8238 +1
====================================================
Hits 15754 15754
- Misses 18171 18173 +2
Partials 51 51
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested on Android real device. Confirmed the issue on place_of_birth
.
## Short description Depends on #5310, #5315 and #5321. This PR introduces a refactors in how we render the claims list. The general idea behind this refactor is that we are parsing the `unknown` value of a claim with io-ts decoders to known which kind of claim we are manipulating, thus rendering an appropriate component to display it. ## List of changes proposed in this pull request - Defines a set of decoders for our claims; - Adds a `itwCredentialClaim.tsx` which decodes the claim and renders the appropriate component; - Align `ItwCredentialClaimsList.tsx` to the new changes; - Moves every claim related util to `ItwClaimsUtils`. ## How to test Test the available credentials, each claim should be render properly formatted. --------- Co-authored-by: Mario Perrotta <mario.perrotta@pagopa.it>
Short description
This PR introduces the health card issuance issuance.
Note: there's an issue with the place of birth claim which is going to addressed in a separate issue (SIW-681). Since the component which renders the claims list needs a substantial refactor I decided to leave it out of the scope of this PR. See #5321.
List of changes proposed in this pull request
How to test
With an valid wallet test the health card issuance flow.