Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IP-86] tslint to eslint migration #18

Merged
merged 5 commits into from
Apr 15, 2021
Merged

Conversation

michaeldisaro
Copy link
Contributor

@michaeldisaro michaeldisaro commented Apr 2, 2021

List of Changes

  • Deleted tslint.json file
  • Removed tslint packages from package.json
  • Created .eslintignore ignore file
  • Created .eslintrc.js configuration
  • Added some lint exclusions to .eslintrc.js to avoid a deep refactoring of working code
  • Changed tslint's "rule disabling" comments with eslint closest ones.

Motivation and Context

We want to migrate to eslint because tslint is deprecated.

How Has This Been Tested?

It has been tested by performing:

  • yarn install --frozen-lockfile
  • yarn build
  • yarn lint
  • yarn test

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

.eslintignore Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@michaeldisaro
Copy link
Contributor Author

@BurnedMarshal @balanza I fixed broken tests, removed global ignores and made some of your requested fixes. Let me know if we need anything else to merge. Tests passed and build works.

Copy link
Contributor

@BurnedMarshal BurnedMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from a minor change. Thanks @michaeldisaro

src/utils/environment.ts Outdated Show resolved Hide resolved
Copy link

@balanza balanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart minor, non blocking comments

@michaeldisaro michaeldisaro merged commit de70088 into master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants