-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#IP-86] tslint to eslint migration #18
Conversation
@BurnedMarshal @balanza I fixed broken tests, removed global ignores and made some of your requested fixes. Let me know if we need anything else to merge. Tests passed and build works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from a minor change. Thanks @michaeldisaro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart minor, non blocking comments
List of Changes
tslint.json
filepackage.json
.eslintignore
ignore file.eslintrc.js
configuration.eslintrc.js
to avoid a deep refactoring of working codeMotivation and Context
We want to migrate to eslint because tslint is deprecated.
How Has This Been Tested?
It has been tested by performing:
Types of changes
Checklist: