Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove executable bit from users.json #64

Merged
merged 2 commits into from
Jan 18, 2021

Conversation

bfabio
Copy link
Contributor

@bfabio bfabio commented Jan 16, 2021

Remove the unneeded executable bit from a non-executable JSON file.

@codecov
Copy link

codecov bot commented Jan 16, 2021

Codecov Report

Merging #64 (efc90e1) into master (56e2e28) will increase coverage by 0.79%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   66.26%   67.06%   +0.79%     
==========================================
  Files          11       11              
  Lines         750      759       +9     
  Branches      117      116       -1     
==========================================
+ Hits          497      509      +12     
+ Misses        252      249       -3     
  Partials        1        1              
Impacted Files Coverage Δ
src/config.ts 100.00% <ø> (ø)
src/strategy/spid.ts 37.20% <0.00%> (+0.25%) ⬆️
src/index.ts 64.19% <92.85%> (+4.77%) ⬆️
src/utils/response.ts 45.45% <0.00%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0f1709...38c7b17. Read the comment docs.

Copy link
Contributor

@balanza balanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Can you please update the PR description to explain why these changes are needed and what's the benefit?

@bfabio
Copy link
Contributor Author

bfabio commented Jan 18, 2021

@balanza done. This is a simple chmod -x, nothing fancy.

@balanza balanza self-requested a review January 18, 2021 15:42
@balanza balanza merged commit b1271e7 into pagopa:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants