Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix required attributes value from config #75

Merged
merged 2 commits into from
May 11, 2021
Merged

Conversation

BurnedMarshal
Copy link
Contributor

The value of requiredAttributes is taken from the serviceProviderConfig instead of a static value.

@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Apr 28, 2021

Warnings
⚠️ Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS against 4e51f8d

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #75 (8bbb8fd) into master (56e2e28) will increase coverage by 0.79%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   66.26%   67.06%   +0.79%     
==========================================
  Files          11       11              
  Lines         750      759       +9     
  Branches      117      123       +6     
==========================================
+ Hits          497      509      +12     
+ Misses        252      249       -3     
  Partials        1        1              
Impacted Files Coverage Δ
src/config.ts 100.00% <ø> (ø)
src/strategy/spid.ts 37.20% <0.00%> (+0.25%) ⬆️
src/utils/middleware.ts 92.30% <ø> (ø)
src/index.ts 64.19% <92.85%> (+4.77%) ⬆️
src/utils/response.ts 45.45% <0.00%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a29a77c...8bbb8fd. Read the comment docs.

Copy link
Contributor

@AleDore AleDore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AleDore AleDore merged commit 458894b into master May 11, 2021
@AleDore AleDore deleted the fix-required-attributes branch May 11, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants