Enable Avviso SPID n°19 only with public full operator #81

AleDore · 2021-05-12T08:50:59Z

This PR allows compliance with Avviso SPID n° 19 v4 only for the PublicServicesFullOperator extension.

pagopa-github-bot · 2021-05-12T08:54:13Z

	Warnings
⚠️	Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

single story: [#123456] my PR title
multiple stories: [#123456,#123457,#123458] my PR title

New dependencies added: request-ip.

request-ip

Author: Petar Bojinov

Description: A small node.js module to retrieve the request's IP address

Homepage: https://github.com/pbojinov/request-ip


Created	over 7 years ago
Last Updated	over 2 years ago
License	MIT
Maintainers	1
Releases	21
Direct Dependencies	`is_js`
Keywords	request ip, ip, address, request, proxy, client, header, X-Client-IP, X-Forwarded-For, CF-Connecting-IP, Fastly-Client-IP, True-Client-IP, X-Real-IP, X-Cluster-Client-IP, X-Forwarded, Forwarded-For, connection.remoteAddress, connection.socket.remoteAddress, req.info.remoteAddress, middleware, ipv4 and ipv6

README

request-ip

A tiny Node.js module for retrieving a request's IP address.

Installation

npm install request-ip --save

Getting Started

const requestIp = require('request-ip');

// inside middleware handler
const ipMiddleware = function(req, res, next) {
    const clientIp = requestIp.getClientIp(req); 
    next();
};

// on localhost you'll see 127.0.0.1 if you're using IPv4 
// or ::1, ::ffff:127.0.0.1 if you're using IPv6

As Connect Middleware

const requestIp = require('request-ip');
app.use(requestIp.mw())

app.use(function(req, res) {
    const ip = req.clientIp;
    res.end(ip);
});

To see a full working code for the middleware, check out the examples folder.

The connect-middleware also supports retrieving the ip address under a custom attribute name, which also works as a container for any future settings.

How It Works

It looks for specific headers in the request and falls back to some defaults if they do not exist.

The user ip is determined by the following order:

X-Client-IP
X-Forwarded-For (Header may return multiple IP addresses in the format: "client IP, proxy 1 IP, proxy 2 IP", so we take the the first one.)
CF-Connecting-IP (Cloudflare)
Fastly-Client-Ip (Fastly CDN and Firebase hosting header when forwared to a cloud function)
True-Client-Ip (Akamai and Cloudflare)
X-Real-IP (Nginx proxy/FastCGI)
X-Cluster-Client-IP (Rackspace LB, Riverbed Stingray)
X-Forwarded, Forwarded-For and Forwarded (Variations of Bump lodash from 4.17.11 to 4.17.15 #2)
req.connection.remoteAddress
req.socket.remoteAddress
req.connection.socket.remoteAddress
req.info.remoteAddress

If an IP address cannot be found, it will return null.

Samples Use Cases

Getting a user's IP for geolocation.

Running the Tests

Make sure you have the necessary dev dependencies needed to run the tests:

npm install

Run the integration tests

npm test

Release Notes

See the wonderful changelog

To easily generate a new changelog, install github-changelog-generator then run npm run changelog.

Contributors

Thanks to @osherx for adding the connect-middleware.
Thanks to @raunc for adding Squid proxy support.
Thanks to @fluxsauce for adding CF-Connecting-IP, True-Client-IP, and ES6 support.
Thanks to @vishalvijay for adding Fastly/Firebase hosting support.

License

The MIT License (MIT) - 2018

Generated by 🚫 dangerJS against 8a50188

BurnedMarshal · 2021-05-12T12:54:50Z

src/example.ts

  spidTestEnvUrl: "https://spid-testenv2:8088",
-  spidValidatorUrl: "http://localhost:8080",
+  // spidValidatorUrl: "http://localhost:8080",


Add a comment to explain why this line is commented. Later we can fix the spid-saml-check docker image to re-enable that configuration.

BurnedMarshal · 2021-05-12T12:58:15Z

src/example.ts

@@ -72,13 +77,29 @@ const serviceProviderConfig: IServiceProviderConfig = {
    ],
    name: "Required attrs"
  },
-  spidCieUrl: "https://idserver.servizicie.interno.gov.it:8443/idp/shibboleth",
+  spidCieUrl: "https://idserver.servizicie.interno.gov.it:443/idp/shibboleth",


Can we use the new test endpoint for CIE metadata https://preproduzione.idserver.servizicie.interno.gov.it/idp/shibboleth?Metadata
Reference from here

BurnedMarshal · 2021-05-12T12:59:47Z

src/example.ts

@@ -116,7 +137,7 @@ app.use(passport.initialize());
 // Create a Proxy to forward local calls to spid validator container
 const proxyApp = express();
 proxyApp.get("*", (req, res) => {
-  res.redirect("http://spid-saml-check:8080" + req.path);
+  res.redirect("localhost:8080" + req.path);


this works only with an active spid-saml-check

BurnedMarshal · 2021-05-12T13:07:46Z

src/utils/middleware.ts

+const CommonExtension = t.partial({
+  FiscalCode: t.string,
+  IPACode: t.string,
+  VATNumber: t.string
+});


This fileds are all required for a Gestore

Suggested change

const CommonExtension = t.partial({

FiscalCode: t.string,

IPACode: t.string,

VATNumber: t.string

});

const CommonExtension = t.interface({

FiscalCode: t.string,

IPACode: t.string,

VATNumber: t.string

});

BurnedMarshal

LGTM

src/example.ts

BurnedMarshal and others added 5 commits December 24, 2020 17:53

[#176261561] Aggregator types SPID configuration

c0ecadd

[#176261561] Fix Billing Contact type

170c13f

[#176261561] extensions for aggregated and aggregator, billing

6820953

[#176261561] Remove useless type PrivateAggregatorExtension

bff32a3

Enable Avviso SPID n°19 v4

6074423

AleDore requested review from balanza, BurnedMarshal, francescopersico and gunzip as code owners May 12, 2021 08:50

Rebase

784c761

AleDore added 2 commits May 12, 2021 11:06

fix lint

04ba473

keep only PublicServicesFullOperator

bd66c21

AleDore changed the title ~~Enable Avviso SPID n°19 without public full aggregator~~ Enable Avviso SPID n°19 only with public full operator May 12, 2021

BurnedMarshal requested changes May 12, 2021

View reviewed changes

Refactor over review

225c1ec

AleDore requested a review from BurnedMarshal May 12, 2021 13:26

BurnedMarshal previously approved these changes May 12, 2021

View reviewed changes

src/example.ts Outdated Show resolved Hide resolved

Update src/example.ts

8a50188

BurnedMarshal dismissed their stale review via 8a50188 May 12, 2021 13:27

BurnedMarshal approved these changes May 12, 2021

View reviewed changes

AleDore merged commit 2b5f3a5 into master May 12, 2021

AleDore deleted the spid_aggregator_without_public_full branch May 12, 2021 13:31

bfabio mentioned this pull request Jun 4, 2021

Introduced HTTPS, private sp ContactPerson nodes on metadata, fix for /error without 200 http code italia/spid-express#43

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable Avviso SPID n°19 only with public full operator #81

Enable Avviso SPID n°19 only with public full operator #81

AleDore commented May 12, 2021 •

edited

Loading

pagopa-github-bot commented May 12, 2021 •

edited

Loading

request-ip

Installation

Getting Started

As Connect Middleware

How It Works

Samples Use Cases

Running the Tests

Release Notes

Contributors

License

BurnedMarshal May 12, 2021

BurnedMarshal May 12, 2021

BurnedMarshal May 12, 2021

BurnedMarshal May 12, 2021

BurnedMarshal left a comment

Enable Avviso SPID n°19 only with public full operator #81

Enable Avviso SPID n°19 only with public full operator #81

Conversation

AleDore commented May 12, 2021 • edited Loading

pagopa-github-bot commented May 12, 2021 • edited Loading

request-ip

request-ip

Installation

Getting Started

As Connect Middleware

How It Works

Samples Use Cases

Running the Tests

Release Notes

Contributors

License

BurnedMarshal May 12, 2021

Choose a reason for hiding this comment

BurnedMarshal May 12, 2021

Choose a reason for hiding this comment

BurnedMarshal May 12, 2021

Choose a reason for hiding this comment

BurnedMarshal May 12, 2021

Choose a reason for hiding this comment

BurnedMarshal left a comment

Choose a reason for hiding this comment

AleDore commented May 12, 2021 •

edited

Loading

pagopa-github-bot commented May 12, 2021 •

edited

Loading