Refs #87 Add support for dynamic port forwarding #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 12, 2017 22:33
- Add possibility to completely disable logging - Add possibility to explicitly set SSH TIMEOUT - Catch ValueError, EOFError when paramiko transport is created
|
IMHO it should not be accepted without tests for the new functionality.
El 29 abr. 2017 6:05 p. m., "Sorin Srn" <notifications@github.com> escribió:
… This is related to issue #87
<#87>
Please review my changes and if you accept them I will try to add unit and
functional tests also.
------------------------------
You can view, comment on, or merge this pull request online at:
#93
Commit Summary
- Add support for dynamic port forwarding
- - Add Magic Const to a global variable
File Changes
- *M* sshtunnel.py
<https://github.com/pahaz/sshtunnel/pull/93/files#diff-0> (181)
Patch Links:
- https://github.com/pahaz/sshtunnel/pull/93.patch
- https://github.com/pahaz/sshtunnel/pull/93.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#93>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AG-TbLMVqWHgogR3QHRi8yAG-br_2z-Wks5r01_DgaJpZM4NMTG9>
.
|
|
What about tests? And README example? |
|
Any news about the PR? |
|
This looks like an excellent addition; any chance of finishing it? TIA. |
|
As I said, please manually TEST and confirm that everything works, and afterwords I'll add tests / README example and I'll create a new pull request. |
|
https:// github.com /paramiko/paramiko/blob/5cd4a085a11940436111b6b6f93aa369c9fb2a92/demos/demo_socks_proxy.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to issue #87
Please review my changes and if you accept them I will try to add unit and functional tests also.