Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mz as a production dependency. Instead use pify for promisifying. #154

Merged
merged 1 commit into from
Mar 4, 2018
Merged

Remove mz as a production dependency. Instead use pify for promisifying. #154

merged 1 commit into from
Mar 4, 2018

Conversation

realityking
Copy link
Contributor

mz sticks around as a dev dependency

@pahen
Copy link
Owner

pahen commented Feb 28, 2018

What's the reason for this change?

@realityking
Copy link
Contributor Author

Sorry, should've explained that in the first post. mz is not the smallest dependency (it pulls in 4 more dependency) and it's only used in madge to promisify these 4 methods.

@pahen
Copy link
Owner

pahen commented Feb 28, 2018

Ok, I see :) Why keep mz as a dev dependency and not use pify there too?

@realityking
Copy link
Contributor Author

realityking commented Feb 28, 2018

That's not as easy as a test uses the exists method ). exists isn't actually part of fs but something that mz implemented.

The test using exists is this one:

madge/test/api.js

Lines 263 to 264 in 7fce4b7

return fs
.exists(imagePath)

@pahen
Copy link
Owner

pahen commented Mar 4, 2018

Ok, I see. Then I have no problem with merging this :)

@pahen pahen merged commit b6f62c3 into pahen:master Mar 4, 2018
@realityking realityking deleted the drop-mz branch March 4, 2018 18:56
nmeylan pushed a commit to nmeylan/madge that referenced this pull request Jan 7, 2020
Remove mz as a production dependency. Instead use pify for promisifying.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants