Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excel error handling #341

Merged
merged 2 commits into from Apr 29, 2022
Merged

Excel error handling #341

merged 2 commits into from Apr 29, 2022

Conversation

cyberop5
Copy link
Contributor

Enforce DataRange/Dataset when creating ExcelFileDefinitions.
Current behavior: Throws a null reference exception because reader.DataRange is null.
Change:

  1. Check that the WithDataset address isn't null.
  2. Throw a more descriptive null reference exception when calling GetExcelReader.
  3. Throw a more helpful null reference exception when trying to read a row without a DataRange.

Enforce DataRange/Dataset when creating ExcelFileDefinitions.
@cyberop5 cyberop5 marked this pull request as ready for review April 28, 2022 23:12
@paillave paillave merged commit f6f45b5 into paillave:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants