Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable autogen.sh, so libtool and automake are not required #59

Closed
wants to merge 1 commit into from

Conversation

dominictarr
Copy link
Contributor

I removed this, and it still installed just fine, on tested on (arch)linux and on osx.

Following from @jsedisct1's comment #52 (comment)

This makes it much easier to install my application which uses node-sodium, which makes it easier for people to use it and for devs to contribute to it.

@paixaop
Copy link
Owner

paixaop commented Oct 16, 2015

It does compile in MAC and some linux distributions but not in others. Originally node sodium was compiled without these tools, but it was causing a lot of problems in ARM platforms and others.
It's a bit more complex but platform independent.

@dominictarr
Copy link
Contributor Author

how should I go about compiling for arm? which linux distros does it not compile on?

@paixaop
Copy link
Owner

paixaop commented Oct 16, 2015

I dug back on some old issues and here's one distro that fails #34

@dominictarr
Copy link
Contributor Author

What about if I change this so that it attempted autogen.sh, but if it failed it would continue to install (with useful warning message)?
Then you'll only need to install those tools if you really need it, and in most cases it will just work.

@paixaop
Copy link
Owner

paixaop commented Oct 16, 2015

I think that works. It's a great idea.

@reqshark
Copy link

reqshark commented Apr 4, 2016

Following from @jedisct1's comment #52 (comment)

i think he just meant you dont need autogen w/ release tarball, but you probably do for git compile

@paixaop
Copy link
Owner

paixaop commented Apr 6, 2016

The newer branch libsodium-1.0.8-update changes the libsodium compile stage. If there's a pre compiled library in the /deps/build/lib mode sodium will use it instead of trying to compile from source. If a library, and include directory, are not found they it uses libsodium's own compilation scripts to build a static version of the library.

This will make it easier to download a binary distribution from Libsodium Releases and not rely on the build system if it does not work well in you platform.

@paixaop paixaop closed this Apr 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants