Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax yamllint comment space constraint. #826

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Relax yamllint comment space constraint. #826

merged 1 commit into from
Oct 9, 2023

Conversation

robdimsdale
Copy link
Member

Summary

This PR removes a yamllint check requiring a minimum number of spaces between the # and the start of the comment.

Use Cases

We do not find this lint check improves readability and we consistently forget to adhere to it.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@robdimsdale
Relax yamllint comment space constraint.
4a9404e 
- We do not find this lint check improves readability and we consistently forget to adhere to it.
@robdimsdale robdimsdale requested a review from a team as a code owner October 9, 2023 20:40
@sophiewigmore sophiewigmore enabled auto-merge (squash) October 9, 2023 20:41
@sophiewigmore sophiewigmore merged commit bb8711f into main Oct 9, 2023
3 checks passed
@sophiewigmore sophiewigmore deleted the remove-yaml-lint-min-spaces branch October 9, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophiewigmore sophiewigmore sophiewigmore approved these changes

@ryanmoran ryanmoran Awaiting requested review from ryanmoran ryanmoran is a code owner automatically assigned from paketo-buildpacks/tooling-maintainers

@paketo-bot-reviewer paketo-bot-reviewer Awaiting requested review from paketo-bot-reviewer paketo-bot-reviewer is a code owner automatically assigned from paketo-buildpacks/tooling-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robdimsdale @sophiewigmore